Fix Microsoft connector emailToLowercase for refresh token #3699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dexidp#3283 Signed-off-by: Atte Niemi <4998544+hur@users.noreply.github.com>
hur
force-pushed
the
fix/microsoft-connector-email-refresh
branch
from
49bb349
to
66b68d8
Compare
hur
changed the title
Signed-off-by: Atte Niemi <4998544+hur@users.noreply.github.com>
hur
force-pushed
the
fix/microsoft-connector-email-refresh
branch
from
379d639
to
83a852a
Compare
hur
commented
Aug 16, 2024
| expectEquals(t, identity.Email, "jane.doe@example.com") | ||
| expectEquals(t, identity.EmailVerified, true) | ||
| expectEquals(t, len(identity.Groups), 0) | ||
|
|
There was a problem hiding this comment.
I didn't add a check for expectEquals(t, identity.ConnectorData, expectedConnectorData) (like in gitea_test.go, for example) as I wasn't sure if there's a good way to mock the Expiry time from a quick look around the codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3283
Overview
Respect the
emailToLowercaseconfig in theRefresh()functionWhat this PR does / why we need it
Updates the
Refreshfunction to also consider the config optionemailToLowercase.Special notes for your reviewer
I have added unit tests. I have not tested in practice - I don't have a access to a Microsoft tenant.