feat(metrics): add response_size, request_duration histograms #3748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoGoman
force-pushed
the
feat/handler-metrics
branch
from
eace25e
to
09d9346
Compare
|
LGTM! The only problem is the signature
|
replaces felixge/httpsnoop with prometheus/client_golang instrumentation adds histograms for response_size_bytes & request_duration_seconds Signed-off-by: Ivo Gosemann <ivo.gosemann@sap.com>
IvoGoman
force-pushed
the
feat/handler-metrics
branch
from
09d9346
to
9fd348f
Compare
nabokihms
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change adds additional handler metrics
response_size_bytesandrequest_duration_seconds.It replaces the dependency for
felixge/httpsnoopwith functions from prometheus/client_golangWhat this PR does / why we need it
Closes #3698
Special notes for your reviewer
I have used default buckets for the histograms. I will try over the next week to get a custom build into my own QA landscape, in order to validate the buckets.