feat: set resource revision for connectors #3868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicholas Wiersma <nick@wiersma.co.za>
nrwiersma
force-pushed
the
connector-resource-revisions
branch
from
86eebc6 to
8405be6
Compare
|
I didn't find how it fixes the original problem, but still think that the change is ok. |
The issue is that updates to a Connector in the API are ignored because the ResourceVersion, which is empty, does not change, and therefore needs a restart of Dex to get the updated Connector. By adding and incrementing the ResourceVersion field, this solves the observed issue. |
nabokihms
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds resource versions to connectors that are API controlled but default. It does not require the Connector to use the resource revision, so that Kubernetes still functions.
What this PR does / why we need it
This fixes an issue with connectors where updates to a connector via the API does not get applied to the runtime use of the connector. This seems to have been previously fixed for Kubernetes specifically, but this is a more general fix.
Fixes #3855
Special notes for your reviewer
I see no obvious way to test this, but if I am missing something, please let me know.