player/player.go: added handler for fire extinguish #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
It seems to actually work as expected. 2024-07-18.17-04-36.mp4 |
aabstractt
commented
Jul 18, 2024
| @@ -55,6 +55,9 @@ type Handler interface { | |||
| // HandleSkinChange handles the player changing their skin. ctx.Cancel() may be called to cancel the skin | |||
| // change. | |||
| HandleSkinChange(ctx *event.Context, skin *skin.Skin) | |||
| // HandleFireExtinguish handles the player extinguishing a fire at a specific position. ctx.Cancel() may | |||
| // be called to cancel the fire being extinguished. | |||
| HandleFireExtinguish(ctx *event.Context, pos cube.Pos) | |||
| // HandleStartBreak handles the player starting to break a block at the position passed. ctx.Cancel() may | |||
| // be called to stop the player from breaking the block completely. | |||
| HandleStartBreak(ctx *event.Context, pos cube.Pos) | |||
There was a problem hiding this comment.
I see it as necessary when wanting to cancel the fire extinguishment only in some positions, you cannot use the player's position, since both positions are different than expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.