Improve + consolidate cycle detection #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 99.63% 99.67% +0.03%
==========================================
Files 47 47
Lines 11519 11557 +38
==========================================
+ Hits 11477 11519 +42
+ Misses 42 38 -4
|
dfed
commented
Jul 7, 2024
| .union(scope.properties), | ||
| property: property, | ||
| .union(scope.properties) | ||
| .removing(childProperty), |
There was a problem hiding this comment.
brought this line back from #95. Now that we're doing our cycle checking before we're doing our "initialized in chain" checking, we can make this more semantically correct
dfed
commented
Jul 7, 2024
| @@ -351,58 +351,43 @@ actor ScopeGenerator: CustomStringConvertible, Sendable { | |||
| private var generateCodeTask: Task<String, Error>? | |||
|
|
|||
| private var orderedPropertiesToGenerate: [ScopeGenerator] { | |||
| get throws { | |||
There was a problem hiding this comment.
we no longer need to throw here since we do this checking much earlier now. best reviewed with whitespace turned off
dfed
commented
Jul 7, 2024
Comment on lines
+963
to
+964
| Dependency received in same chain it is instantiated! | ||
| @Instantiated a: A -> @Received renamedB: B -> @Received c: C -> @Received a: A |
There was a problem hiding this comment.
this test better mirrors the above test. I liked the parallelism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #95 by fully consolidating our cycle detection + further improving the error message we emit when receiving a property that isn't yet fully instantiated.