Enable Xcode 16 plugin to use versioned release build #109
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| // Distributed under the MIT License | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in all | ||
| // copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| // SOFTWARE. | ||
|
|
||
| import Foundation | ||
| import PackagePlugin | ||
|
|
||
| @main | ||
| struct InstallSafeDITool: CommandPlugin { | ||
| func performCommand( | ||
| context: PackagePlugin.PluginContext, | ||
| arguments _: [String] | ||
| ) async throws { | ||
| guard let safeDIOrigin = context.package.dependencies.first(where: { $0.package.displayName == "SafeDI" })?.package.origin else { | ||
| Diagnostics.error("No package origin found for SafeDI package") | ||
| exit(1) | ||
| } | ||
| switch safeDIOrigin { | ||
| case let .repository(url, displayVersion, _): | ||
| // As of Xcode 16.0 Beta 6, the display version is of the form "Optional(version)". | ||
| // This regular expression is duplicated by SafeDIGenerateDependencyTree since plugins can not share code. | ||
| guard let versionMatch = try /Optional\((.*?)\)|^(.*?)$/.firstMatch(in: displayVersion), | ||
| let versionSubstring = versionMatch.output.1 ?? versionMatch.output.2 | ||
|
There was a problem hiding this comment. Why checking There was a problem hiding this comment. Ditto in the copied code in the other plugin There was a problem hiding this comment. I'm falling back to a version with no surrounding |
||
| else { | ||
| Diagnostics.error("Could not extract version for SafeDI") | ||
| exit(1) | ||
| } | ||
| let version = String(versionSubstring) | ||
| let safediFolder = context.package.directoryURL.appending( | ||
| component: ".safedi" | ||
| ) | ||
| let expectedToolFolder = safediFolder.appending( | ||
| component: version | ||
| ) | ||
| let expectedToolLocation = expectedToolFolder.appending(component: "safeditool") | ||
|
|
||
| guard let url = URL(string: url)?.deletingPathExtension() else { | ||
| Diagnostics.error("No package url found for SafeDI package") | ||
| exit(1) | ||
| } | ||
| #if arch(arm64) | ||
| let toolName = "SafeDITool-arm64" | ||
| #elseif arch(x86_64) | ||
| let toolName = "SafeDITool-x86_64" | ||
| #else | ||
| Diagnostics.error("Unexpected architecture type") | ||
| exit(1) | ||
| #endif | ||
|
|
||
| let githubDownloadURL = url.appending( | ||
| components: "releases", | ||
| "download", | ||
| version, | ||
| toolName | ||
| ) | ||
| let (downloadedURL, _) = try await URLSession.shared.download( | ||
| for: URLRequest(url: githubDownloadURL) | ||
| ) | ||
| let downloadedFileAttributes = try FileManager.default.attributesOfItem(atPath: downloadedURL.path()) | ||
| guard let currentPermissions = downloadedFileAttributes[.posixPermissions] as? NSNumber, | ||
| // Add executable attributes to the downloaded file. | ||
| chmod(downloadedURL.path(), mode_t(currentPermissions.uint16Value | S_IXUSR | S_IXGRP | S_IXOTH)) == 0 | ||
| else { | ||
| Diagnostics.error("Failed to make downloaded file \(downloadedURL.path()) executable") | ||
| exit(1) | ||
| } | ||
| try FileManager.default.createDirectory( | ||
| at: expectedToolFolder, | ||
| withIntermediateDirectories: true | ||
| ) | ||
| try FileManager.default.moveItem( | ||
| at: downloadedURL, | ||
| to: expectedToolLocation | ||
| ) | ||
| let gitIgnoreLocation = safediFolder.appending(component: ".gitignore") | ||
| if !FileManager.default.fileExists(atPath: gitIgnoreLocation.path()) { | ||
| try """ | ||
| */\(expectedToolLocation.lastPathComponent) | ||
| """.write( | ||
| to: gitIgnoreLocation, | ||
| atomically: true, | ||
| encoding: .utf8 | ||
| ) | ||
| } | ||
|
|
||
| case .registry, .root, .local: | ||
| fallthrough | ||
|
|
||
| @unknown default: | ||
| Diagnostics.error("Cannot download SafeDITool from \(safeDIOrigin) – downloading only works when using a versioned release of SafeDI") | ||
| exit(1) | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apple... why...
Using
displayVersionis clearly brittle, but it does work.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Watch them add a space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seemed like an oversight. We'll see swiftlang/swift-package-manager#7934
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this ever fully breaks we can do what Apollo does and hardcode the current release version. I'd prefer to trust SPM rather than have to keep this in-sync myself, so we're starting out with this approach.