Adopt Xcode 16. Drop support for Xcode 15 #112
Conversation
dfed
force-pushed
the
dfed--xcode-16
branch
from
ebacf28
to
82571b8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
- Coverage 99.67% 99.52% -0.16%
==========================================
Files 33 33
Lines 2778 2713 -65
==========================================
- Hits 2769 2700 -69
- Misses 9 13 +4
|
dfed
force-pushed
the
dfed--xcode-16
branch
5 times, most recently
from
69b92e2
to
8716e6b
Compare
| #if canImport(FoundationNetworking) | ||
| import FoundationNetworking | ||
| #endif |
There was a problem hiding this comment.
networking is split out from Foundation on Linux, apparently
dfed
force-pushed
the
dfed--xcode-16
branch
from
8716e6b
to
01fac84
Compare
| chmod(downloadedURL.path(), mode_t(currentPermissions.uint16Value | S_IXUSR | S_IXGRP | S_IXOTH)) == 0 | ||
| chmod(downloadedURL.path(), mode_t(currentPermissions.uint32Value) | S_IXUSR | S_IXGRP | S_IXOTH) == 0 |
There was a problem hiding this comment.
On Linux mode_t is a UInt32. On Apple's platforms it is a UInt16. So I need to wrap the mode_t cast on the currentPermissions value alone, and I figured I'd downscale the UInt32 value rather upscaling the UInt16 value. Doesn't really make a difference in the end though.
| sudo xcodebuild -runFirstLaunch | ||
| sudo xcrun simctl list | ||
| sudo xcodebuild -downloadPlatform visionOS | ||
| sudo xcodebuild -runFirstLaunch |
There was a problem hiding this comment.
Per actions/runner-images#10559 what we had before was incomplete.
|
Merging this, but happy to take review comments post-merge. Not planning on releasing this change until a few more things land. |
Examples/ExamplePackageIntegration/Sources/SharedModule/UserDefaults.swift
Outdated
Show resolved
Hide resolved
…ercise more code paths
This is a breaking change. I have no planned additional features for Xcode 15 / Swift 5, so it feels reasonable to cut a major version and drop support in new releases.