Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This makes
candid::Error
clonable, which makes it easier for downstream clients to also make theirError
types cloneable.I've made a related PR for agent-rs.
Considered Solutions
I can also work around by using
Arc<T>
in downstream clients.Considerations
This shouldn't have any impact on security or performance. Anyone that was interacting directly with the
Custom
variant may have a breaking change since it is wrapped in anArc<T>
now.