Basic example for best-effort response calls #1069
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't currently test if it works as it seems that `msg_deadline` has gone missing from the current HEAD of the Rust CDK's next branch.
oggy-dfin
requested review from
derlerd-dfinity,
alin-at-dfinity and
stiegerc
| @@ -0,0 +1,5 @@ | |||
| [workspace] | |||
| members = [ | |||
| "src/berc_backend" | |||
There was a problem hiding this comment.
From Google:
Dictionary
Definitions from Oxford Languages · Learn more
berk
/bəːk/noun informal • British
a stupid person.
I'd personally stick with best_effort or be. (o:
| "canisters": { | ||
| "berc_backend": { | ||
| "candid": "src/berc_backend/ber_backend.did", | ||
| "package": "berc_backend", |
There was a problem hiding this comment.
See above, regarding "berk". (o:
Comment on lines
79
to
80
| #[ic_cdk::query(composite = true)] | ||
| async fn test_deadlines_in_composite_query() -> (u64, u64) { |
There was a problem hiding this comment.
Do we actually do anything at all with deadlines in composite queries, beyond exposing them to the callee? Should we?
There was a problem hiding this comment.
We ended up specifying this:
For other calls (ingress messages and all calls to query and composite query methods, including calls in replicated mode) a deadline of 0 is returned.
The implementation is consistent with that. I've added this to the README now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until best-effort responses are available on mainnet.
This is a draft that I can't currently test, as it seems that
msg_deadlinehas gone AWOL in the process of overhauling Rust CDK's next branch, but putting it up to get feedback before Christmas.Overview
Why do we need this feature? What are we trying to accomplish?
Requirements
What requirements are necessary to consider this problem solved?
Considered Solutions
What solutions were considered?
Recommended Solution
What solution are you recommending? Why?
Considerations
What impact will this change have on security, performance, users (e.g. breaking changes) or the team (e.g. maintenance costs)?