Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update canister_logs examples with replicated query cases #928

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

maksymar
Copy link
Contributor

@maksymar maksymar commented Jul 3, 2024

This PR adds more cases to the canister logging examples in Rust and Motoko.

Specifically it adds a case of recording logs in a query method called in replicated mode.
It also adds separate tests for each canister logging example case.

@maksymar maksymar marked this pull request as ready for review July 3, 2024 10:00
@maksymar maksymar requested a review from a team as a code owner July 3, 2024 10:00
@maksymar maksymar requested review from dsarlis, mraszyk and a team and removed request for a team July 3, 2024 10:00
rust/canister_logs/Makefile Outdated Show resolved Hide resolved
@maksymar maksymar requested a review from mraszyk July 3, 2024 10:12
@maksymar maksymar merged commit b098916 into master Jul 3, 2024
6 checks passed
@maksymar maksymar deleted the maksym/logging-replicated-query branch July 3, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants