Skip to content

Commit

Permalink
add logs and upgrade chorme in other jobs
Browse files Browse the repository at this point in the history
  • Loading branch information
lmuntaner committed Jan 9, 2025
1 parent 71db1bf commit acaa9fc
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/canister-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,9 @@ jobs:
TLS_DEV_SERVER=1 NO_HOT_RELOAD=1 npm run dev | tee -a > dev-server-logs.txt &
dev_server_pid=$!
echo "dev_server_pid=$dev_server_pid" >> "$GITHUB_OUTPUT"
chromedriver --version
google-chrome --version
node --version
# run unit tests & e2e tests
# NOTE: we run chrome in headless mode because that's the only thing that works in GHA
Expand Down
2 changes: 1 addition & 1 deletion demos/using-dev-build/wdio.conf.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const config: WebdriverIO.Config = {
capabilities: [
{
browserName: "chrome",
browserVersion: "122.0.6261.111", // More information about available versions can be found here: https://github.com/GoogleChromeLabs/chrome-for-testing
browserVersion: "134.0.6946.0", // More information about available versions can be found here: https://github.com/GoogleChromeLabs/chrome-for-testing
"goog:chromeOptions": {
args: ["headless", "disable-gpu", "disable-dev-shm-usage"],
},
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/screenshots.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ async function withChrome<T>(
const browser = await remote({
capabilities: {
browserName: "chrome",
browserVersion: "122.0.6261.111", // More information about available versions can be found here: https://github.com/GoogleChromeLabs/chrome-for-testing
browserVersion: "134.0.6946.0", // More information about available versions can be found here: https://github.com/GoogleChromeLabs/chrome-for-testing
"goog:chromeOptions": chromeOptions,
},
});
Expand Down

0 comments on commit acaa9fc

Please sign in to comment.