-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show support links on loading and error screens. #2702
Show support links on loading and error screens. #2702
Conversation
* Show support links on loading and error screens. * Update css * Update comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Could you provide a screenshot of how the new loader screen looks like?
|
||
.c-loader__link:hover, | ||
.c-loader__link:focus { | ||
color: var(--rc-surface); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you change the color on hover? We do that for the secondary button
Thanks! Does that feel like a button? How about changing the color on hover? |
More than the style, I think it's the text that doesn't make it look like a button. It needs a verb. How about "Go to ongoing issues" |
Remove "false" label from loader screen, previously introduced in #2702.
Right now both loading and error screens don't link users to support, this PR adds support links on both these screens.
Both links go to the same support page, this page will be updated to document common errors and ongoing issues over time.
🟡 Some screens were changed