Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show support links on loading and error screens. #2702

Merged

Conversation

sea-snake
Copy link
Contributor

@sea-snake sea-snake commented Nov 21, 2024

Right now both loading and error screens don't link users to support, this PR adds support links on both these screens.

  • The loading overlay shows a "Ongoing issues" link if it is shown longer than 10s.
  • The error screen has a secondary button "Go to support" below the "Try again" button.

Both links go to the same support page, this page will be updated to document common errors and ongoing issues over time.


🟡 Some screens were changed

@sea-snake sea-snake requested review from lmuntaner and LXIF November 21, 2024 13:47
@sea-snake sea-snake requested a review from a team as a code owner November 21, 2024 13:47
@sea-snake sea-snake added this pull request to the merge queue Nov 21, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 21, 2024
* Show support links on loading and error screens.

* Update css

* Update comment
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2024
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you provide a screenshot of how the new loader screen looks like?

@sea-snake
Copy link
Contributor Author

Could you provide a screenshot of how the new loader screen looks like?

The link would only appear below the astronaut in the case, the user is stuck for a while (after 10 sec).

image


.c-loader__link:hover,
.c-loader__link:focus {
color: var(--rc-surface);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you change the color on hover? We do that for the secondary button

@lmuntaner
Copy link
Collaborator

The link would only appear below the astronaut in the case, the user is stuck for a while (after 10 sec).

Thanks! Does that feel like a button? How about changing the color on hover?

@lmuntaner
Copy link
Collaborator

The link would only appear below the astronaut in the case, the user is stuck for a while (after 10 sec).

Thanks! Does that feel like a button? How about changing the color on hover?

More than the style, I think it's the text that doesn't make it look like a button. It needs a verb.

How about "Go to ongoing issues"

@sea-snake sea-snake enabled auto-merge November 22, 2024 09:06
@sea-snake sea-snake added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 437124a Nov 22, 2024
67 checks passed
@sea-snake sea-snake deleted the sea-snake/show-support-links-on-loading-and-error-screens branch November 22, 2024 09:19
github-merge-queue bot pushed a commit that referenced this pull request Nov 29, 2024
Remove "false" label from loader screen, previously introduced in #2702.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants