Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are scenarios where the RP ID selected is not the correct one for the device the user is in. When that happens, we want to tell the user to try again, but this time, we will select another RP ID.
In this PR, I introduce the logic to use another RP ID on retry. See the video for a demo of how it looks like.
What I haven't improved in this PR is the UX when retrying. I'm thinking on only improving the toast error for now and if users are confused improve it. But this is an edge case that I hope not so many people will encounter.
Changes
excludeCredentialsFromOrigins
andhasCredentialsFromMultipleOrigins
.Connection
:_cancelledRpIds
to keep track of the cancelled RP IDs._cancelledRpIds
to filter the devices with the cancelled RP IDs from the calculation to find the next RP ID.Tests
excludeCredentialsFromOrigins
.🟡 Some screens were changed