Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tabulateVar #596

Merged
merged 1 commit into from
Nov 4, 2023
Merged

fix tabulateVar #596

merged 1 commit into from
Nov 4, 2023

Conversation

chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity enabled auto-merge (squash) November 4, 2023 17:30
crusso
crusso approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@crusso crusso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might even be better to just use a new prim for this, or reuse Array_tabulate at the mutable type

@chenyan-dfinity chenyan-dfinity merged commit 4f0e103 into master Nov 4, 2023
4 checks passed
@chenyan-dfinity chenyan-dfinity deleted the chenyan-dfinity-patch-1 branch November 4, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomeata nomeata nomeata approved these changes

@crusso crusso crusso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenyan-dfinity @crusso @nomeata