feat: add Text.from(Var)Array
#674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggreif
added a commit
that referenced
this pull request
Dec 4, 2024
Using `fromIter` is probably less-than-optimal performance-wise, but we can add a compiler primitive if it proves to become a bottleneck. For now it fills a hole that I perceived in the Motoko AI hackathon. Adds test for both `Text.fromArray` and `fromVarArray`.
ggreif
added a commit
that referenced
this pull request
Dec 4, 2024
Using `fromIter` is probably less-than-optimal performance-wise, but we can add a compiler primitive if it proves to become a bottleneck. For now it fills a hole that I perceived in the Motoko AI hackathon. Adds test for both `Text.fromArray` and `fromVarArray`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
fromIteris probably less-than-optimal performance-wise, but we can add a compiler primitive if it proves to become a bottleneck. For now it fills a hole that I perceived in the Motoko AI hackathon.Adds test for both
Text.fromArrayandfromVarArray.