Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment: allow stable/flexible modifiers before top-level actor(class) declarations to flip defaults. #4779

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

crusso
Copy link
Contributor

@crusso crusso commented Nov 25, 2024

The only way to fit this into the grammar is for top-level actor declarations (class libraries and programs), but that's all we support when compiling to the IC anyway...

Benefits:

  • backward compatible
  • opt-in
  • no new keywords (though we could add synonyms for flexible/stable if we like).

Copy link

github-actions bot commented Nov 25, 2024

Comparing from aebc110 to a7298cd:
The produced WebAssembly code seems to be completely unchanged.

@@ -268,6 +271,10 @@
'flexible'
'stable'

<stab_mod> ::=
'flexible'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't like the option of

flexible actor (class...)

we could just rule this production out...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant