Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(frontend): add transaction modals to unified transactions list (#…
…3474) # Motivation We need to include the transactions modals to provide the details of the selected transactions. Since there is no unique way of identifying a transaction for each network, we define different selected transactions for each one. This is what is done in all the other network-specific transaction components. # Note Another approach to this, would have been to do like we did for the Transaction card, meaning mapping the modal to each transaction. No particular preference on either method, just pointing out: ```svelte {#if nonNullish(selectedTransaction) && ($modalBtcTransaction || $modalEthTransaction || $modalIcTransaction)} <svelte:component this={selectedTransaction.modal} transaction={selectedTransaction} /> {/if} ``` # Tests ![Screenshot 2024-11-14 at 19 07 15](https://github.com/user-attachments/assets/e4190720-fa2c-4db3-8a72-d99c72ebda09) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
- Loading branch information