Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): Page for Terms and Conditions #3116

Merged
merged 15 commits into from
Oct 25, 2024
Merged

feat(frontend): Page for Terms and Conditions #3116

merged 15 commits into from
Oct 25, 2024

Conversation

AntonioVentilii-DFINITY
Copy link
Contributor

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY commented Oct 25, 2024 •
edited
Loading

Motivation

We need a Terms and Condition page for OISY. The text was approved by Legal team. So, in this PR, we define the component to be used.

Screen.Recording.2024-10-25.at.11.11.12.mov

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY marked this pull request as ready for review October 25, 2024 09:16
@AntonioVentilii-DFINITY AntonioVentilii-DFINITY requested a review from a team as a code owner October 25, 2024 09:16
@AntonioVentilii-DFINITY
Copy link
Contributor Author

AntonioVentilii-DFINITY commented Oct 25, 2024 •
edited by jira bot
Loading

OISY-122

peterpeterparker
peterpeterparker reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to rename the route group (terms-and-conditions) to (public).

The +layout can maybe remain at the root of the group.

Ideally I would provide two PRs, one to initialize the public route, another for its content but fine if we keep it here.

src/frontend/src/lib/components/terms-and-conditions/TermsAndConditions.svelte Outdated Show resolved Hide resolved
src/frontend/src/routes/(terms-and-conditions)/terms-and-conditions/+page.ts Outdated Show resolved Hide resolved
@AntonioVentilii-DFINITY
Copy link
Contributor Author

@peterpeterparker you are right, new PR for the route:

peterpeterparker
peterpeterparker approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTm, thx

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY merged commit c766ba2 into main Oct 25, 2024
11 checks passed
@AntonioVentilii-DFINITY AntonioVentilii-DFINITY deleted the feat(frontend)/Page-for-Terms-and-Conditions branch October 25, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntonioVentilii-DFINITY @peterpeterparker @AntonioVentilii