Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): Rename dAppname to dAppName #3228

Merged

Conversation

AntonioVentilii-DFINITY
Copy link
Contributor

Motivation

Small refactoring to change dAppname to dAppName, and to not use the name variable that it was giving a deprecation warning by the dom.

Screenshot 2024-10-29 at 22 00 57

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY marked this pull request as ready for review October 29, 2024 21:07
@AntonioVentilii-DFINITY AntonioVentilii-DFINITY requested a review from a team as a code owner October 29, 2024 21:07
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

😉

Joke beside, thanks. Nicer!

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY merged commit bd62c1a into main Oct 30, 2024
12 checks passed
@AntonioVentilii-DFINITY AntonioVentilii-DFINITY deleted the refactor(frontend)/Rename-dAppname-to-dAppName branch October 30, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants