Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): adjust title for dapp explorer #3249

Merged
merged 3 commits into from
Oct 31, 2024
Merged

feat(frontend): adjust title for dapp explorer #3249

merged 3 commits into from
Oct 31, 2024

Conversation

loki344
Copy link
Collaborator

@loki344 loki344 commented Oct 31, 2024 •
edited
Loading

Motivation

Adjust title of DappExplorer according to spec.

Changes

Explore Web3 Ecosystem => Explore apps

Tests

Before
image
image

After
image
image

@loki344 loki344 marked this pull request as ready for review October 31, 2024 08:06
@loki344 loki344 requested a review from a team as a code owner October 31, 2024 08:06
AntonioVentilii-DFINITY
AntonioVentilii-DFINITY reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My opinion: shouldn't be Explore dApps ? Or was it on purpose

src/frontend/src/lib/i18n/en.json Outdated Show resolved Hide resolved
@loki344 loki344 enabled auto-merge (squash) October 31, 2024 15:24
@loki344 loki344 merged commit 93eacd6 into main Oct 31, 2024
11 checks passed
@loki344 loki344 deleted the feat(frontend)/change-dapp-explorer-header branch October 31, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanBerger-DFINITY StefanBerger-DFINITY StefanBerger-DFINITY left review comments

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY AntonioVentilii-DFINITY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loki344 @AntonioVentilii-DFINITY @StefanBerger-DFINITY