feat(frontend): isIcToken and isIcTokenCanistersStrict validation #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioVentilii
approved these changes
Nov 5, 2024
peterpeterparker
added a commit
that referenced
this pull request
Nov 5, 2024
# Motivation As discussed offline in the context of #3357. We actually adopt a new convention in which Zod schema related are provided in sub-folder `schema`. This prevents the introduction of circular dependencies when the validation uses both types and Zod schema. # Changes - Rename `ic-token.validation` to `ic-token.schema`
peterpeterparker
changed the title
|
As discussed offline: we ultimally agreed those were "validation" and not "utils". So we proceeded with some refactoring and I finally renamed the code of this PR from "utils" to "validation". |
|
Relates to #2883 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We will need to know if IC tokens are provided with or without Index Canister ID. Unrelated but, somehow related, we also want to know if a token is just a token or an IC token.
Notes
Some test uncommented and will be activated in PR #3334 because they cannot be active unless the Index Canister ID is set to optional.
Changes
isIcToken,isNotIcToken,isIcTokenCanistersStrictandisNotIcTokenCanistersStrict