feat(frontend): remove indexCanisterVersion #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
All SNSes have upgraded their Index Canister version to
-ngseveral months ago. Therefore, theindexCanisterVersioninformation is no longer necessary.Notes
The weekly job was interesting because it reported Index Canisters as "outdated" when they were out of cycles. However, detecting such issues is not entirely our responsibility. Additionally, the job incorrectly flagged them as "outdated" due to a failing assertion that checked the error message to determine if they were out of cycles. This assertion stopped working because the error message text had changed. Long story short, we decided to remove the check.
Changes
indexCanisterVersionin code.