Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple packages in one repository. #38

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

matthewhammer
Copy link

#37

@matthewhammer matthewhammer marked this pull request as draft November 9, 2021 18:54
@matthewhammer
Copy link
Author

This PR is still a draft, but it may be ready enough for initial feedback from @kritzcreek, for an initial sanity check. Going to change to "ready for review", even though there is probably more to do before reviewing fully.

@matthewhammer matthewhammer marked this pull request as ready for review November 9, 2021 19:52
@kritzcreek
Copy link
Collaborator

Hey, I agree this is a desirable feature. I'm a bit worried about breaking all the package-sets we've put out there so far. Maybe we could make the parameter non-optional, but continue to try and parse the old format for a while? While emitting a warning that we defaulted the path configuration to src for all the packages that were missing it?

Just a suggestion, if you think it's better to rip off the bandaid, I'm happy to approve.

@matthewhammer
Copy link
Author

Maybe we could make the parameter non-optional, but continue to try and parse the old format for a while? While emitting a warning that we defaulted the path configuration to src for all the packages that were missing it?

Okay, I like that idea, and concurrently I had begun to sour on the optional-ness of path, and wanted to also make it mandatory, where people would write "src" to get the current behavior. This evolution path seems natural and good to me! Thanks for taking a look!

@q-uint
Copy link

q-uint commented Jan 15, 2022

Hi @matthewhammer, any plans to pick this up again? Do you need a hand?

@q-uint q-uint mentioned this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants