Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

53 stack trace error in evtxanalyze pstree function #56

Merged
merged 9 commits into from
Jul 29, 2024

Conversation

janstarke
Copy link
Member

@janstarke janstarke commented Jul 23, 2024

fixes #53

@janstarke janstarke added the bug Something isn't working label Jul 23, 2024
@janstarke janstarke requested a review from Bitbee0 July 23, 2024 11:34
@janstarke janstarke linked an issue Jul 23, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.35%. Comparing base (4176a93) to head (cb837c4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   34.35%   34.35%           
=======================================
  Files          36       36           
  Lines        1141     1141           
=======================================
  Hits          392      392           
  Misses        749      749           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janstarke janstarke added this to the 0.11.2 milestone Jul 25, 2024
@Bitbee0
Copy link
Contributor

Bitbee0 commented Jul 29, 2024

Can we maybe fix the warnings from clippy, before merging this branch into main?

warning: using `clone` on type `u64` which implements the `Copy` trait
  --> src/bin/evtxanalyze/pstree/process.rs:62:29
   |
62 |             new_process_id: value.new_process_id.clone(),
   |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `value.new_process_id`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
   = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: using `clone` on type `u64` which implements the `Copy` trait
  --> src/bin/evtxanalyze/pstree/process.rs:65:25
   |
65 |             process_id: value.process_id.clone(),
   |                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `value.process_id`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

@janstarke
Copy link
Member Author

Can we maybe fix the warnings from clippy, before merging this branch into main?

warning: using `clone` on type `u64` which implements the `Copy` trait
  --> src/bin/evtxanalyze/pstree/process.rs:62:29
   |
62 |             new_process_id: value.new_process_id.clone(),
   |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `value.new_process_id`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
   = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: using `clone` on type `u64` which implements the `Copy` trait
  --> src/bin/evtxanalyze/pstree/process.rs:65:25
   |
65 |             process_id: value.process_id.clone(),
   |                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `value.process_id`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Done

@janstarke janstarke merged commit b994ef0 into main Jul 29, 2024
4 checks passed
@janstarke janstarke deleted the 53-stack-trace-error-in-evtxanalyze-pstree-function branch July 29, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack Trace error in evtxanalyze pstree function
2 participants