Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff's the codebase #237

Merged
merged 17 commits into from
Jul 14, 2024
Merged

Ruff's the codebase #237

merged 17 commits into from
Jul 14, 2024

Conversation

dgasmith
Copy link
Owner

Description

Generally "modifies" the codebase by:

  • Switches to the ruff formatter which combines auto flake/black/isort into a single tool with enhanced rules.
  • Switches away from setuptools/setup.py/setup.cfg in favor of a hatch/pyproject.toml equivalent.
  • Removes numpy as an official build dependancy.
  • Moves back to Py3.8 as the minimum version to fully support PyTorch.

Status

  • Ready to go

@dgasmith dgasmith requested a review from jcmgray July 10, 2024 02:20
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.54%. Comparing base (94c62a0) to head (3a8f0b0).

Additional details and impacted files

@dgasmith dgasmith merged commit 1992f4a into main Jul 14, 2024
9 checks passed
@dgasmith dgasmith deleted the ruff branch July 14, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcmgray jcmgray Awaiting requested review from jcmgray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dgasmith