feat: change logging to zap and change how change logs applied #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…also added more tests for admin routes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
+ Coverage 35.79% 37.48% +1.68%
==========================================
Files 113 116 +3
Lines 9372 9457 +85
==========================================
+ Hits 3355 3545 +190
+ Misses 5656 5512 -144
- Partials 361 400 +39 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| proxyState.Logger().Error().Err(err).Msgf("error checking x-forwarded-for ip: %s", xForwardedForIps[i]) | ||
| logger.Error("error checking x-forwarded-for ip", | ||
| zap.String("x-forwarded-for_ip", xForwardedForIps[i]), | ||
| zap.Error(err), |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
uncommend collectiontype add lock to reconfigure state remove ip from logs
bubbajoe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…also added more tests for admin routes