[Mellanox]Removing FEC from port_config.ini for SN5600 SKUs #109
+883
−881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprital
reviewed
Dec 19, 2024
| Ethernet496 496,497,498,499 etp63a 63 400000 | ||
| Ethernet500 500,501,502,503 etp63b 63 400000 | ||
| Ethernet504 504,505,506,507 etp64a 64 400000 | ||
| Ethernet508 508,509,510,511 etp64b 64 400000 | ||
| Ethernet512 512 etp65 65 25000 |
There was a problem hiding this comment.
Please check. There was no such port on the file before the change
There was a problem hiding this comment.
Ethernet512 is not part of the diff and exists even without my changes
noaOrMlnx
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Removed FEC mode from port_config.ini for SN5600 SKUs. FEC mode needs to come as part of user configuration as it depends on peer end capabilities as well.
Work item tracking
How I did it
Modified port_config.ini
How to verify it
Loading the SKU and testing default configuration
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)