[System Ready]Handle template value for feature table state field #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To fix the issue where system ready state is 'Not ready' while all expected services are ready. This is due to some FEATURE table entries have state value as template and thus in sysmonitor when the value is checked whether its not disabled , the feature is assumed to be enabled and to be started by systemd while the rendering would result in disabled resulting in systemd not starting the feature.
Sysmonitor dnsrvs_name will this have this feature and consider the system wrongly down.
Work item tracking
How I did it
Handled dynamic rendering of the feature
How to verify it
Run UT. Run install of system and ensure system state is not down when all services are up.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)