[DropCounter]Fix the ordering issue with dropcounter #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
During the removal of drop counters, the counter is deleted first followed by removing it from flexcounter. This would result in a race condition where counterpoll might try to access the counter after it is deleted.
Why I did it
To fix the error log appearing when drop counter is removed. The SAI object is removed during object destroy. Hence destroying the counter after flex counter is disabled.
https://github.com/sonic-net/sonic-swss/blob/67e03128dedc061c51da7ccd7fd716f00d974bb3/orchagent/debug_counter/drop_counter.cpp#L101
How I verified it
The existing sonic-swss UT should verify the drop counters functionality.
Details if related