Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised Issue #9 Added Account Edit Fragment and use POJO in controller #37

Closed
wants to merge 7 commits into from

Conversation

krishnarb3
Copy link

No description provided.

@krishnarb3
Copy link
Author

Revised #9
I have made the discussed changes.

-> MenuActivity
>Added EventBus onUiEventRecieved for editing user account in fragment
>Added onBackPressed for fragment transaction from edit account fragment to display account fragment

->AccountEditFieldAdapter
>Not display error in editText when email is valid
>EdittextListener doesnt listen for fields other than Email

->UiEvent : added new UiEvent USER_ACCOUNT_EDIT
->Changed from EditAccount Activity to AccountEditFragment
->Account Fragment : on clicking edit button post UiEvent USER_ACCOUNT_EDIT to EventBus

->Increment recyclerView Library dependency to v7.23.1.1
>Causes Bugs (MotionEvent causes NullPointerException) otherwise

@arazabishov : Please acknowledge if there are any changes to be made.

@krishnarb3 krishnarb3 changed the title Added Account Edit Fragment and use POJO in controller Revised #9 Added Account Edit Fragment and use POJO in controller Mar 16, 2016
@krishnarb3 krishnarb3 changed the title Revised #9 Added Account Edit Fragment and use POJO in controller Revised Issue #9 Added Account Edit Fragment and use POJO in controller Mar 16, 2016
@arazabishov
Copy link
Contributor

@krishnarb3 Hi Krishna, I will review your changes as soon as possible and will publish feedback here.

@krishnarb3
Copy link
Author

@arazabishov Thank you , Sir

@krishnarb3
Copy link
Author

krishnarb3 commented Apr 16, 2016

@arazabishov
I have added a new commit with working Account Manager
Solves Issue #10
Basic testing of Account Manager done , extensive testing ongoing to prevent bugs.

@krishnarb3
Copy link
Author

Please review the code and suggest changes.
Thank you.

@arazabishov
Copy link
Contributor

Hi @krishnarb3,

We are currently working on completely new version of dashboard app based on DHIS 2 android SDK. SDK itself already contains profile fragment implementation which we are planning to re-use in dashboard app as well.

What we can do is to take some bits and pieces of your implementation which can complete SDK's profile fragment (you can also do this if you want). I recommend you to take a look into https://github.com/dhis2/dhis2-android-eventcapture repository in order to get better understanding of what we have already done.

Thanks a lot for you contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants