FormatROD - multi-axis goniometer and faster decompression
#186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validate the handedness by anomalous signals)
indexing of multiple scans
|
Why was this closed immediately? I added one more commit 094fc7b to better document my code. I think the branch is ready to be merged. There is one high RMSD dataset but the diffraction spots are not very good. I believe the new multiaxis geometry is correct (but ideally this should be validated by some strongly anomalous datasets). |
As you saw, I opened it on the wrong fork. |
DiamondLightSource-build-server
pushed a commit
that referenced
this pull request
Aug 3, 2023
`FormatROD` - multi-axis goniometer and faster decompression #186 --------- Co-authored-by: Takanori Nakane <nakane.t@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@biochem-fan I took the liberty of making a PR from your branch, mainly because it took me a moment to find it again when I wanted to try something. If you are happy with it, let's merge and then that sets a common base to figure out issues like those with the viewers.