Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak gain for ELDICO ED-1 #200

Closed
wants to merge 2 commits into from
Closed

Tweak gain for ELDICO ED-1 #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89f78b1
Gain is not well known, so reset to 1.0
dagewa Apr 30, 2024
3cd750b
News
dagewa Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/xxx.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
``FormatBrukerED1``: the gain is not well-known, so reset to 1.0 and allow the user to override at import.
7 changes: 4 additions & 3 deletions src/dxtbx/format/FormatCBFMiniEigerQuadroED1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,12 @@ def _detector(self):
mask=[],
)

# Here we set specifics, notably gain=3, also parallax correction and
# Here we set specifics: parallax correction and
# QE correction are effectively disabled by setting the simple
# pixel-to-millimetre strategy and a very high mu value.
# pixel-to-millimetre strategy and a very high mu value. Gain is not
# precisely known. We think it might be around 1.7, but here will leave
# as 1.0 and expect the user to override at import.
for panel in detector:
panel.set_gain(3)
panel.set_thickness(thickness)
panel.set_material(material)
panel.set_identifier(identifier)
Expand Down
Loading