Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flumpy: Suppress a pybind11 warning on recent compilers #206

Closed
wants to merge 1 commit into from
Closed

Flumpy: Suppress a pybind11 warning on recent compilers #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/XXX.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Suppress a flumpy warning coming from pybind11. See https://github.com/pybind/pybind11/issues/5224.
7 changes: 7 additions & 0 deletions src/dxtbx/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,13 @@ if(HAS_VISIBILITY)
target_compile_options(dxtbx_flumpy PRIVATE -fvisibility=hidden)
endif()

# pybind11 causes a bounds checking warning on recent compilers
check_cxx_compiler_flag("-Wno-array-bounds" HAS_BOUNDS_WARNING)
check_cxx_compiler_flag("-Wno-stringop-overread" HAS_OVERREAD_WARNING)
if(HAS_BOUNDS_WARNING AND HAS_OVERREAD_WARNING)
target_compile_options(dxtbx_flumpy PRIVATE -Wno-array-bounds -Wno-stringop-overread)
endif()

install(
TARGETS
dxtbx_ext
Expand Down
Loading