CelView: Add dragging for mouse #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetektoza
force-pushed
the
add_mouse_dragging
branch
2 times, most recently
from
97c855d
to
ae3e542
Compare
tetektoza
force-pushed
the
add_mouse_dragging
branch
from
ae3e542
to
bbe7442
Compare
tetektoza
force-pushed
the
add_mouse_dragging
branch
from
bbe7442
to
4ee4934
Compare
tetektoza
force-pushed
the
add_mouse_dragging
branch
2 times, most recently
from
db0fa63
to
25b6d45
Compare
|
Would it make sens to have it be shace+click like in PhotoShop or middle button like in GIMP? |
tetektoza
force-pushed
the
add_mouse_dragging
branch
2 times, most recently
from
b607665
to
a3fe172
Compare
I've remade it so it uses middle mouse button for dragging as we've agreed. |
|
I noticed one issue, when you start a drag move it always assumes the scroll bars are at 0x0, so if you have it zoomed to a degree where something is more then 1 screen off there is no way to get to it via dragning. |
tetektoza
force-pushed
the
add_mouse_dragging
branch
2 times, most recently
from
4cfb4d7
to
c790b86
Compare
This patch adds dragging for mouse, so by pressing middle mouse button dragging mode is being changed to scroll hand drag, basically it allows to navigate on the image without pressing scroll bars. To do that, View class had to be introduced which has been introduced to override some of QGraphicsView mouse events and to promote QGraphicsView widget to it.
This patch promotes QGraphicsView widget to View class in LevelCelView/CelView ui forms, so events for mouse can be dispatched properly.
tetektoza
force-pushed
the
add_mouse_dragging
branch
from
c790b86
to
6941d94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds dragging for mouse, so by pressing middle mouse button dragging mode is being changed to scroll hand drag, basically it allows to navigate on the image without pressing scroll bars.
Adds this functionality:
dragging.mp4