switch to using c++ compiler instead of g++ to fix cpp-demos on mac os x #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o MQFIntegration
|
Hmm, switching to pull into master so that we get continuous integration goin'. |
|
(closing and reopening seems to be the easiest way to trigger a new build) |
…g setup.py to use -lstdc++ on darwin
|
hi again @shokrof, suggest opening yet another new pull request for you to experiment, rather than using this one. I'd like to avoid confusing each other with weird test changes :). See also #1859 (comment) |
|
I am thinking of developing a bot to brute force all the options for the compiler. It may have better intuition than me. |
|
Bug is fixed in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try fixing compile errors for
cpp-demoson Mac OS X, ref #1859 (comment), by switching to using the system C++ rather than g++.This will be a pull request into #1859 after Travis finishes checking it.
I've also updated from the latest master branch, so this will update
MQFintegrationto be mergable.