Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Directa Converter #141

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

lorenzo-deluca
Copy link

Added

  • ✨ New converter: Directa

Fixes

Checklist

  • Added relevant changes to README (if applicable)
  • Added relevant test(s)
  • Updated GitVersion file and corresponding version in package.json

Related issue (if applicable)

Fixes #..

@dickwolff
Copy link
Owner

Thanks for this PR, I appreciate you taking the time to add this converter. As I'm currently a bit behind on issues, I hope you don't me looking into those first. As soon as those are cleared up (as far as possible), I'll take a look at this PR.

@lorenzo-deluca
Copy link
Author

Hello @dickwolff , no problem, my pleasure ;)
In the meantime, I am looking for a few users who are also valid with their account (via my fork repository).

Copy link
Owner

@dickwolff dickwolff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done a first review of your changes. Overall looking good, just some small things to finish things up.

Please let me know when you're ready for a final review and merge as soon as you're done with your internal testing and you are satisfied with it! Again, thanks for this change!

src/converters/directaConverter.test.ts Show resolved Hide resolved
src/converters/directaConverter.ts Outdated Show resolved Hide resolved
src/converter.ts Show resolved Hide resolved
@dickwolff
Copy link
Owner

dickwolff commented Jan 4, 2025

I’m nearly at the end of working through the backlog of issues. I’ll rebase your branch tomorrow and do a final review, assuming you’re ready 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants