-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Directa Converter #141
base: main
Are you sure you want to change the base?
Conversation
Thanks for this PR, I appreciate you taking the time to add this converter. As I'm currently a bit behind on issues, I hope you don't me looking into those first. As soon as those are cleared up (as far as possible), I'll take a look at this PR. |
Hello @dickwolff , no problem, my pleasure ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done a first review of your changes. Overall looking good, just some small things to finish things up.
Please let me know when you're ready for a final review and merge as soon as you're done with your internal testing and you are satisfied with it! Again, thanks for this change!
I’m nearly at the end of working through the backlog of issues. I’ll rebase your branch tomorrow and do a final review, assuming you’re ready 😉 |
Added
Fixes
Checklist
package.json
Related issue (if applicable)
Fixes #..