-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👷 Update order of pytest coverage comment #1231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because pytest reports fail on errors, preventing comments of test failures being posted (we only ever see comments of successful test results)
K8s Regression Test Coverage
|
ff137
force-pushed
the
update-pytest-report
branch
from
December 12, 2024 10:37
d72f2bd
to
f0d5971
Compare
K8s Test Coverage
|
K8s Regression Test Coverage
|
ff137
force-pushed
the
update-pytest-report
branch
from
December 12, 2024 10:52
f0d5971
to
97e5bce
Compare
|
|
|
|
ff137
force-pushed
the
update-pytest-report
branch
from
December 12, 2024 12:03
ef5fbe6
to
11c6ded
Compare
|
|
ff137
force-pushed
the
update-pytest-report
branch
from
December 12, 2024 12:31
7feac47
to
4766cff
Compare
K8s Test Coverage
|
K8s Regression Test Coverage
|
ff137
force-pushed
the
update-pytest-report
branch
from
December 12, 2024 12:54
4766cff
to
2314003
Compare
Quality Gate passedIssues Measures |
K8s Test Coverage
|
K8s Regression Test Coverage
|
rblaine95
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "pytest reports" job fails on errors, which will prevent the next pytest comment job to not be posted. So, we only ever see pytest coverage comments of successful test results. This rearranges it so we see comment of test failures too
I'm also debugging to ensure the report correctly omits excluded files from coverage
Edit: the dockerignore was not copying the pyproject.toml file, so the coverage omit rule wasn't being applied. Then, since the rule is to ignore /tests/, and the capi-test dockerfile has workdir called
/tests
, it took some struggling to identify that workdir has to be renamed. Now, coverage is correctly computed for capi-test