Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add guards for indexing when drawing on CR, busycursor when updating display on W/L,Handle interop elements #304

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

sjswerdloff
Copy link
Collaborator

@sjswerdloff sjswerdloff commented Oct 25, 2023

I can split out the three aspects (forgot to branch for each individually).
The CR ROI still doesn't "work" but this at least avoids a crash and will allow further investigation into what prevents CR ROI from working as desired

add busycursor context when updating window/level using W/L bars (doesn't display on MacOS)
Commented example on how to error out for missing IOD Specific element (CT Slice Location)
Workaround for missing SliceLocation
This was linked to issues Oct 25, 2023
@sjswerdloff sjswerdloff changed the title Re-add RT Ion Plan support, add guards for indexing when drawing on CR, Handle interop elements Re-add RT Ion Plan support, add guards for indexing when drawing on CR, busycursor when updating display on W/L,Handle interop elements Oct 25, 2023
using HTML <br> to tidy up the QMessageBox
calling QMessageBox.critical() rather than about()
@sjswerdloff sjswerdloff changed the title Re-add RT Ion Plan support, add guards for indexing when drawing on CR, busycursor when updating display on W/L,Handle interop elements add guards for indexing when drawing on CR, busycursor when updating display on W/L,Handle interop elements Oct 25, 2023
@sjswerdloff sjswerdloff requested a review from didymo October 25, 2023 06:26
@sjswerdloff sjswerdloff self-assigned this Oct 25, 2023
@sjswerdloff sjswerdloff added bug Something isn't working enhancement New feature or request labels Oct 25, 2023
@sjswerdloff sjswerdloff marked this pull request as ready for review October 25, 2023 06:27
@sjswerdloff sjswerdloff merged commit dc1f91a into didymo:master Oct 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RT Ion Plan no longer supported Study ID
1 participant