-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically produce a CBMC release twice per month #8425
base: develop
Are you sure you want to change the base?
Conversation
This new workflow will create a pull request proposing a CBMC release every 14th and 28th of each month.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8425 +/- ##
===========================================
+ Coverage 77.86% 78.38% +0.52%
===========================================
Files 1726 1726
Lines 189890 188613 -1277
Branches 18221 18266 +45
===========================================
Hits 147849 147849
+ Misses 42041 40764 -1277 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like I'd like the descriptions/documentation to be clearer that this creates a new minor release, and only triggers if there have been changes to develop since the last release (of any kind).
echo >> CHANGELOG.tmp | ||
cat -s CHANGELOG.new >> CHANGELOG.tmp | ||
rm CHANGELOG.new | ||
cho >> CHANGELOG.tmp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo?
cho >> CHANGELOG.tmp | ||
cat CHANGELOG >> CHANGELOG.tmp | ||
mv CHANGELOG.tmp CHANGELOG | ||
# update version strings in source tree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TO be clear, this is only in specific config files, not the whole "source tree"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found what looks like an error/typo (unless cho
is a command I'm not familiar with).
Overall looks good. I do wonder if the documentation/descriptions could be clearer in a few places. That is, make it very clear the scope of the changes, this is an automatic minor release update, etc. That said, only the typo would be a reason to block.
This new workflow will create a pull request proposing a CBMC release every 14th and 28th of each month.