fix: Add strongly typed return type for forChild() in ItemCounterModu…

…le, which is necessary in Angular 18.
digipolisantwerp · Aug 20, 2024 · ec3969b · ec3969b
1 parent b174df5
commit ec3969b
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 
 ## Unreleased
 
+## [6.1.2] - 2024-08-20
+
+### Fixed
+
+- `ngx-pagination`: Add strongly typed return type for forChild() in ItemCounterModule, which is necessary in Angular 18.
+
+### Changed
+- `ngx-calendar`: Changed ModuleWithProviders<any> to specific module in forChild()
+- `ngx-forms`: Changed ModuleWithProviders<any> to specific module in forChild()
+- `ngx-pagination`: Changed ModuleWithProviders<any> to specific module in forChild()
+- `ngx-table`: Changed ModuleWithProviders<any> to specific module in forChild()
+
 ## [6.1.1] - 2024-07-02
 
 ### Fixed

diff --git a/lerna.json b/lerna.json
@@ -2,5 +2,5 @@
   "packages": [
     "packages/*"
   ],
-  "version": "6.1.1"
+  "version": "6.1.2"
 }
diff --git a/packages/ngx-calendar/src/lib/calendar.module.ts b/packages/ngx-calendar/src/lib/calendar.module.ts
@@ -41,7 +41,7 @@ export class CalendarModule {
   static forChild(
     weekdayLabels: WeekdayLabelsConfig,
     monthLabels: MonthLabelsConfig
-  ): ModuleWithProviders<any> {
+  ): ModuleWithProviders<CalendarModule> {
     return {
       ngModule: CalendarModule,
       providers: [

diff --git a/packages/ngx-forms/src/lib/upload/upload.module.ts b/packages/ngx-forms/src/lib/upload/upload.module.ts
@@ -25,7 +25,7 @@ import { ValidationMessagesService } from './services/validation-messages.servic
   providers: [ValidationMessagesService, { provide: UPLOAD_VALIDATION_MESSAGES, useValue: {} }],
 })
 export class UploadModule {
-  static forChild(validationMessages: ValidationMessages = {}): ModuleWithProviders<any> {
+  static forChild(validationMessages: ValidationMessages = {}): ModuleWithProviders<UploadModule> {
     return {
       ngModule: UploadModule,
       providers: [{ provide: UPLOAD_VALIDATION_MESSAGES, useValue: validationMessages }],

diff --git a/packages/ngx-leaflet/package.json b/packages/ngx-leaflet/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@acpaas-ui/ngx-leaflet",
-  "version": "6.1.1",
+  "version": "6.1.2",
   "publishConfig": {
     "access": "public"
   },

diff --git a/packages/ngx-pagination/src/lib/item-counter/item-counter.module.ts b/packages/ngx-pagination/src/lib/item-counter/item-counter.module.ts
@@ -1,4 +1,4 @@
-import { NgModule } from '@angular/core';
+import { ModuleWithProviders, NgModule } from '@angular/core';
 import { CommonModule } from '@angular/common';
 import { FormsModule } from '@angular/forms';
 import { IconModule } from '@acpaas-ui/ngx-icon';
@@ -31,7 +31,7 @@ export class ItemCounterModule {
   static forChild(
     itemCounterLabel: Label,
     itemsPerPageLabel: Label
-  ) {
+  ): ModuleWithProviders<ItemCounterModule> {
     return {
       ngModule: ItemCounterModule,
       providers: [

diff --git a/packages/ngx-pagination/src/lib/pagination/pagination.module.ts b/packages/ngx-pagination/src/lib/pagination/pagination.module.ts
@@ -19,7 +19,7 @@ import { PaginationComponent } from './components/pagination/pagination.componen
 export class PaginationModule {
   static forChild(
     paginationLabels: PaginationLabels
-  ): ModuleWithProviders<any> {
+  ): ModuleWithProviders<PaginationModule> {
     return {
       ngModule: PaginationModule,
       providers: [{ provide: PAGINATION_LABELS, useValue: paginationLabels }],

diff --git a/packages/ngx-table/src/lib/components/table/table.component.html b/packages/ngx-table/src/lib/components/table/table.component.html
@@ -1,6 +1,6 @@
 <div
   [ngClass]="{
-    'a-table-scrollable-wrapper': responsive,
+    'a-table-responsive-wrapper': responsive,
     'has-first-column-fixed': fixedColumnLeft,
     'has-last-column-fixed': fixedColumnRight
   }"