Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VSCode starting daml IDE #19723

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Fix VSCode starting daml IDE #19723

merged 1 commit into from
Aug 6, 2024

Conversation

samuel-williams-da
Copy link
Contributor

Forward port of #19722

@samuel-williams-da samuel-williams-da linked an issue Aug 6, 2024 that may be closed by this pull request
VSCode's nodejs bump breaks IDE #19721
Open
dylant-da
dylant-da approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@dylant-da dylant-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuel-williams-da samuel-williams-da enabled auto-merge (squash) August 6, 2024 15:37
@samuel-williams-da samuel-williams-da merged commit cae13a9 into main Aug 6, 2024
14 checks passed
@samuel-williams-da samuel-williams-da deleted the sw/child-process-shell-fix-3.x branch August 6, 2024 16:19
nycnewman pushed a commit that referenced this pull request Sep 10, 2024
@samuel-williams-da @nycnewman
Fix VSCode starting daml IDE (#19723)
b11ce97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylant-da dylant-da dylant-da approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VSCode's nodejs bump breaks IDE
2 participants
@samuel-williams-da @dylant-da