Merge pull request #10 from ezequielramos/main

fix create watchlist status code returned
digital-divas · Jul 8, 2024 · 342b1da · 342b1da
2 parents c3864bd + 0fbb924
commit 342b1da
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/src/controllers/watch-lists.ts b/src/controllers/watch-lists.ts
@@ -74,13 +74,13 @@ function getWatchLists() {
     return watchLists;
 }
 
-function createWatchList(name: string) {
+function createWatchList(name: string, active: boolean) {
     watchListId++;
     const watchList: WatchList = {
         "id": watchListId,
         "created_date": new Date().toISOString(),
         "modified_date": new Date().toISOString(),
-        "active": true,
+        "active": active,
         "name": name,
         "comment": "",
         "color": "123456",

diff --git a/src/routes/cards.ts b/src/routes/cards.ts
@@ -39,8 +39,6 @@ function loadCardRoutes(app: Express) {
             watchLists = [req.body.watch_lists];
         }
 
-        const watchListsIds = getWatchLists().filter(wl => wl.id != -1).map(wl => wl.id);
-
         if (watchLists.includes(-1)) {
             return res.status(400).json({
                 "traceback": "",
@@ -50,6 +48,8 @@ function loadCardRoutes(app: Express) {
             });
         }
 
+        const watchListsIds = getWatchLists().filter(wl => wl.id != -1).map(wl => wl.id);
+
         for (const watchList of watchLists) {
 
             if (!watchListsIds.includes(watchList)) {

diff --git a/src/routes/watch-lists.ts b/src/routes/watch-lists.ts
@@ -21,9 +21,9 @@ function loadWatchListsRoutes(app: Express) {
             });
         }
 
-        const watchList = createWatchList(req.body.name);
+        const watchList = createWatchList(req.body.name, req.body.active === true);
 
-        return res.status(200).json(watchList);
+        return res.status(201).json(watchList);
     });
 
 }

diff --git a/tests/watch-lists.test.ts b/tests/watch-lists.test.ts
@@ -34,10 +34,11 @@ describe('Watch Lists Route Testing', async () => {
         res = await request.post(`/watch-lists/`)
             .set('Authorization', 'Token ' + token)
             .send({
-                name: 'Company 1'
+                name: 'Company 1',
+                active: true
             })
             .type('application/json');
-        expect(res.statusCode).to.be.equal(200);
+        expect(res.statusCode).to.be.equal(201);
 
         res = await request.get(`/watch-lists/`).set('Authorization', 'Token ' + token);
         expect(res.statusCode).to.be.equal(200);