Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vc 2.0 fix protected terms #173

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

aljones15
Copy link
Contributor

@aljones15 aljones15 commented Feb 5, 2024

Features:

  • Uses a release of the VC 2.0 Context
  • Fixed 2 protected terms name and ed25519Signature2018
  • Changes the VC 2.0 mockCredential to use the V2 examples context
  • Adds the VC 2.0 Examples Context to Test Data

Logs:

protected term { term: 'Ed25519Signature2018' }
localCtx {
  "localCtx": {
    "id": "@id",
    "type": "@type",
    "dc": "http://purl.org/dc/terms/",
    "sec": "https://w3id.org/security#",
    "xsd": "http://www.w3.org/2001/XMLSchema#",
    "EcdsaKoblitzSignature2016": "sec:EcdsaKoblitzSignature2016",
    "Ed25519Signature2018": "sec:Ed25519Signature2018",
    "EncryptedMessage": "sec:EncryptedMessage",
    "GraphSignature2012": "sec:GraphSignature2012",
    "LinkedDataSignature2015": "sec:LinkedDataSignature2015",
    "LinkedDataSignature2016": "sec:LinkedDataSignature2016",
    "CryptographicKey": "sec:Key",
    "authenticationTag": "sec:authenticationTag",
    "canonicalizationAlgorithm": "sec:canonicalizationAlgorithm",
    "cipherAlgorithm": "sec:cipherAlgorithm",
    "cipherData": "sec:cipherData",
    "cipherKey": "sec:cipherKey",
    "created": {
      "@id": "dc:created",
      "@type": "xsd:dateTime"
    },
    "creator": {
      "@id": "dc:creator",
      "@type": "@id"
    },
    "digestAlgorithm": "sec:digestAlgorithm",
    "digestValue": "sec:digestValue",
    "domain": "sec:domain",
    "encryptionKey": "sec:encryptionKey",
    "expiration": {
      "@id": "sec:expiration",
      "@type": "xsd:dateTime"
    },
    "expires": {
      "@id": "sec:expiration",
      "@type": "xsd:dateTime"
    },
    "initializationVector": "sec:initializationVector",
    "iterationCount": "sec:iterationCount",
    "nonce": "sec:nonce",
    "normalizationAlgorithm": "sec:normalizationAlgorithm",
    "owner": {
      "@id": "sec:owner",
      "@type": "@id"
    },
    "password": "sec:password",
    "privateKey": {
      "@id": "sec:privateKey",
      "@type": "@id"
    },
    "privateKeyPem": "sec:privateKeyPem",
    "publicKey": {
      "@id": "sec:publicKey",
      "@type": "@id"
    },
    "publicKeyBase58": "sec:publicKeyBase58",
    "publicKeyPem": "sec:publicKeyPem",
    "publicKeyWif": "sec:publicKeyWif",
    "publicKeyService": {
      "@id": "sec:publicKeyService",
      "@type": "@id"
    },
    "revoked": {
      "@id": "sec:revoked",
      "@type": "xsd:dateTime"
    },
    "salt": "sec:salt",
    "signature": "sec:signature",
    "signatureAlgorithm": "sec:signingAlgorithm",
    "signatureValue": "sec:signatureValue"
  }
}
protected term { term: 'name' }
localCtx {
  "localCtx": {
    "ex": "https://example.org/examples#",
    "schema": "http://schema.org/",
    "rdf": "http://www.w3.org/1999/02/22-rdf-syntax-ns#",
    "3rdPartyCorrelation": "ex:3rdPartyCorrelation",
    "AllVerifiers": "ex:AllVerifiers",
    "AlumniCredential": "ex:AlumniCredential",
    "Archival": "ex:Archival",
    "BachelorDegree": "ex:BachelorDegree",
    "Child": "ex:Child",
    "CLCredentialDefinition2019": "ex:CLCredentialDefinition2019",
    "CLSignature2019": "ex:CLSignature2019",
    "DisputeCredential": "ex:DisputeCredential",
    "IssuerPolicy": "ex:IssuerPolicy",
    "HolderPolicy": "ex:HolderPolicy",
    "Mother": "ex:Mother",
    "PrescriptionCredential": "ex:PrescriptionCredential",
    "RelationshipCredential": "ex:RelationshipCredential",
    "UniversityDegreeCredential": "ex:UniversityDegreeCredential",
    "ZkpExampleSchema2018": "ex:ZkpExampleSchema2018",
    "alumniOf": {
      "@id": "schema:alumniOf",
      "@type": "rdf:HTML"
    },
    "attributes": "ex:attributes",
    "child": {
      "@id": "ex:child",
      "@type": "@id"
    },
    "college": "ex:college",
    "currentStatus": "ex:currentStatus",
    "degree": "ex:degree",
    "degreeSchool": "ex:degreeSchool",
    "degreeType": "ex:degreeType",
    "familyName": "schema:familyName",
    "givenName": "schema:givenName",
    "issuerData": "ex:issuerData",
    "name": {
      "@id": "schema:name",
      "@type": "rdf:HTML"
    },
    "nonRevocationProof": "ex:nonRevocationProof",
    "parent": {
      "@id": "ex:parent",
      "@type": "@id"
    },
    "prescription": "ex:prescription",
    "primaryProof": "ex:primaryProof",
    "referenceId": "ex:referenceId",
    "documentPresence": "ex:documentPresence",
    "evidenceDocument": "ex:evidenceDocument",
    "signature": "ex:signature",
    "signatureCorrectnessProof": "ex:signatureCorrectnessProof",
    "spouse": "schema:spouse",
    "statusReason": "ex:statusReason",
    "subjectPresence": "ex:subjectPresence",
    "verifier": {
      "@id": "ex:verifier",
      "@type": "@id"
    }
  }
}

@aljones15 aljones15 self-assigned this Feb 5, 2024
@aljones15 aljones15 changed the base branch from main to update-vc-2.0 February 5, 2024 15:34
@aljones15 aljones15 marked this pull request as ready for review February 5, 2024 15:37
@codecov-commenter
Copy link

Codecov Report

Merging #173 (f1b675b) into update-vc-2.0 (fdc98f6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@              Coverage Diff               @@
##           update-vc-2.0     #173   +/-   ##
==============================================
  Coverage          89.43%   89.43%           
==============================================
  Files                  5        5           
  Lines                994      994           
==============================================
  Hits                 889      889           
  Misses               105      105           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc98f6...f1b675b. Read the comment docs.

@aljones15 aljones15 merged commit 9ff44fe into update-vc-2.0 Feb 5, 2024
5 checks passed
@aljones15 aljones15 deleted the vc-2.0-fix-protected-terms branch February 5, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants