Create lockout message for mobile users #2763
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrangeAndGreen
approved these changes
Jun 12, 2024
shubham1g5
reviewed
Jun 17, 2024
There was a problem hiding this comment.
Hey @avazirna, Can you describe why we decided to not use existing 406 ? It seems like we are duplicating what 406 is designed to do effortlessly with a 401 here but in a more complicated fashion.
|
@damagatchi retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR presents an appropriate message to users that have been locked out of CommCare due to exceeding the maximum number of login attempts allowed. To restore the account, users need to reach out to a Supervisor or Administrator.
Note: Another design considered during this work involved receiving a
406response code from HQ and let the User Actionable errors feature handle the error message, this option was later disfavoured over a401response code with specific error messages but it can always be revisited if needed.Ticket: https://dimagi.atlassian.net/browse/SAAS-13154
Product Description
Currently, when an user is locked out, they get an
Invalid Username or Passwordmessage. With this change, the message will be:Safety Assurance
Safety story
This PR only improves error message handling on the client side, instead of having a catch-all message for all authentication failure events.