Extend user session #2876
Draft
Extend user session #2876
+82
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham1g5
requested changes
Oct 21, 2024
Comment on lines
+251
to
254
| if (questionsView.hasNonRecoverableWidgets()) { | ||
| CommCareApplication.instance().getSession().extendUserSessionIfNeeded(); | ||
| } | ||
| } |
There was a problem hiding this comment.
I would think a better place to do this would be when user take an action to start the unrecoverable action. For eg. for the audio recording widget we should only extend the session when user initiates the recording and do nothing if user decides to skip the recording widget present in the form. Also if user decies to attach a recording from the FileSystem (instead of live recording through CC) , the session should not be extended.
There was a problem hiding this comment.
@shubham1g5 I have raised a new PR with a new approach to this. On that approach, the extension happens during the widget changed event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the option for CommCare to extend the session of the user when they are navigating a widget that can't be recovered in case of session expiration. In another words, it extends the session to prevent the auto logout from being triggered and the user to lose any data captured using the widget. The widget in question is the CommCareAudioWidget.
This issue came up recently for a project that makes use of this widget to audio record long session in which users were being logout in the middle of the recording due to the session expiration. More information on this ticket.
Safety Assurance
Safety story
This only adds more time to the current session. Local tests were successfully.