Feature/permit lock and process expired locks tests #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you try to check and fix the failed test in CircleCI? 🙏 |
0xhafa
force-pushed
the
feature/permit-lock-and-process-expired-locks-tests
branch
3 times, most recently
from
4716ed8
to
6ad2300
Compare
It didn't require to install foundry to fix the issue. There is a conflict happening when running slither with the |
drahrealm
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Review:
ClaimAndLock()in RelockerprocessExpiredLocksAndRelockRewards()from Relocker (not possible with the current implementation of RLBTRFLY)ClaimAndLock()with permit