Fix issue #20 "unexpected end of JSON input" error #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #20 by correcting the
reader.CreateReader
logic determining whether to use areader.FileReader
orreader.StdinReader
. Previously, in some environments (like GH Actions Ubuntu runners),tf-summarize
incorrectly attempted to use areader.StdinReader
, even when an explicit filename argument is provided.Ideally,
tf-summarize
would feature automated tests through which I could prove the bug & fix.In absence of such tests,I added ademo
GitHub Actions job provingtf-summarize
continues to work.However, I'm happy to add real tests (either in this PR, or in a followup PR), if you prefer those, @dineshba (I'm also happy to remove thedemo
GH Actions job from this PR if you prefer it not clutter.github/workflows/build.yml
).Update: I added 2 additional commits:
example
projecttf-summarize -md plan.json
andcat plan.json | tf-summarize -md
both continue to work as expected.Note that #63 shows reproduction of the bug via a similar GitHub Actions-based demo.