Fix bug with updating existing field and strategies with no params

diogomatoschaves · Feb 12, 2024 · 87ffb34 · 87ffb34
1 parent ff155e7
commit 87ffb34
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/data/sources/binance/load/_load.py b/data/sources/binance/load/_load.py
@@ -55,9 +55,11 @@ def save_new_entry_db(model_class, fields, count_updates=True):
 
             fields_subset = {key: value for key, value in fields.items() if key in unique_fields}
 
-            rows = model_class.objects.filter(**fields_subset).update(**fields)
+            model_class.objects.filter(**fields_subset).delete()
+            with transaction.atomic():
+                new_entry = model_class.objects.create(**fields)
 
-            if rows != 0 and count_updates:
-                new_entry = True
+            if not count_updates:
+                new_entry = False
 
     return new_entry
diff --git a/shared/utils/helpers/_helpers.py b/shared/utils/helpers/_helpers.py
@@ -133,7 +133,10 @@ def get_pipeline_max_window(pipeline_id):
 
         max_value_params = 0
         for strategy in strategies:
-            max_value = max([value for param, value in strategy["params"].items()])
+            try:
+                max_value = max([value for param, value in strategy["params"].items()])
+            except ValueError:
+                continue
 
             if max_value > max_value_params:
                 max_value_params = max_value