Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename vertical to radio prop #45

Merged
merged 1 commit into from
Jul 2, 2024
Merged

feat: rename vertical to radio prop #45

merged 1 commit into from
Jul 2, 2024

Conversation

v8tenko
Copy link
Member

@v8tenko v8tenko commented Jul 2, 2024

No description provided.

vsesh
vsesh approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@vsesh vsesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the major change

@v8tenko
Copy link
Member Author

v8tenko commented Jul 2, 2024

I think it's the major change

why is it? users just want to use with prop "radio"

@vsesh
Copy link
Collaborator

vsesh commented Jul 2, 2024

why is it? users just want to use with prop "radio"

Somebody could have started using the vertical option. After the minor release, their business logic will be broken.

@v8tenko
Copy link
Member Author

v8tenko commented Jul 2, 2024

why is it? users just want to use with prop "radio"

Somebody could have started using the vertical option. After the minor release, their business logic will be broken.

yes, it is. I didn't understand right. vertical mode are in test right now, so it is ok

@v8tenko v8tenko merged commit 70fe497 into master Jul 2, 2024
2 checks passed
@v8tenko v8tenko deleted the rename-tabs-prop branch July 2, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsesh vsesh vsesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v8tenko @vsesh