Skip to content

Commit

Permalink
Fixed subject code not set issue when visualizing with template brain;
Browse files Browse the repository at this point in the history
Fixed atlas list not updated when brain is loaded;
Fixed controller not set because the `value` variable is undefined;
`Voxel Label` input is remembered.
  • Loading branch information
dipterix committed Apr 11, 2024
1 parent 4d0f2a2 commit c1e25e3
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 6 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## Changes since last CRAN release
* `bedd7e38 (HEAD -> master)` [_`dipterix`_]: Fixed name parsing for surface file when `space` keyword is provided
* `fdc5c859 (HEAD -> master)` [_`dipterix`_]: Fixed subject code not set issue when visualizing with template brain; Fixed atlas list not updated when brain is loaded; Fixed controller not set because the `value` variable is undefined; `Voxel Label` input is remembered.
* `4d0f2a23 (origin/master, origin/HEAD)` [_`dipterix`_]: Fixed name parsing for surface file when `space` keyword is provided
* `01836188` [_`dipterix`_]: Added `volume_to_surf` to generate `3D` triangular mesh surfaces from volume data
* `8a3a03e0 (origin/dragndrop, dragndrop)` [_`dipterix`_]: Fixed `Github` action script with system dependecies added
* `aae29b28` [_`dipterix`_]: Color look-up table can be set with arbitrary single color (in `HexString`, indicating that all values should be rendered with such color; Drag & Drop volumes can change to single colors
Expand Down
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: threeBrain
Type: Package
Title: Your Advanced 3D Brain Visualization
Version: 1.1.0.9000
Version: 1.1.0.9001
Authors@R: c(
person("Zhengjia", "Wang", email = "dipterix.wang@gmail.com", role = c("aut", "cre", "cph")),
person("John", "Magnotti", email = "John.Magnotti@Pennmedicine.upenn.edu", role = c("aut", "res")),
Expand Down
2 changes: 2 additions & 0 deletions R/class_multibrain.R
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,8 @@ MultiBrain2 <- R6::R6Class(
optionals = list(), debug = FALSE, token = NULL, browser_external = TRUE, ...
){

controllers <- as.list(controllers)
controllers[["Subject"]] <- self$template_object$subject_code

geoms <- self$template_object$get_geometries( volumes = volumes, surfaces = surfaces, electrodes = TRUE )

Expand Down
2 changes: 1 addition & 1 deletion inst/threeBrainJS/dist/threebrain-main.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion inst/threeBrainJS/dist/threebrain-main.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion inst/threeBrainJS/dist/threebrain-worker.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion inst/threeBrainJS/dist/threebrain-worker.js.map

Large diffs are not rendered by default.

0 comments on commit c1e25e3

Please sign in to comment.